Skip to content

Conversation

zhaomaosu
Copy link
Contributor

This will allow backend compiler to eliminte unnecessary code to reduce kernel code size.

This will allow backend compiler to eliminte unnecessary code to reduce
kernel code size.
@zhaomaosu zhaomaosu marked this pull request as ready for review August 14, 2025 06:48
@zhaomaosu zhaomaosu requested review from a team as code owners August 14, 2025 06:48
@zhaomaosu
Copy link
Contributor Author

Hi @steffenlarsen, I have another question. The pre-ci for testing ABI compatibility is failed due to this PR will indeed break ABI compatibility. However, the ABI compatibility is unimportant to device sanitizer since the user must re-build their code if they want to test their code with device sanitizer. Do you know if there is a way to disable a test under ABI compatibility testing mode?

@steffenlarsen
Copy link
Contributor

Hi @steffenlarsen, I have another question. The pre-ci for testing ABI compatibility is failed due to this PR will indeed break ABI compatibility. However, the ABI compatibility is unimportant to device sanitizer since the user must re-build their code if they want to test their code with device sanitizer. Do you know if there is a way to disable a test under ABI compatibility testing mode?

I believe it should be as simple as adding the tests at the top of devops/compat_ci_exclude.sycl-rel-6_3 with a comment stating why it is OK for it to break compatibility.

@aelovikov-intel
Copy link
Contributor

Hi @steffenlarsen, I have another question. The pre-ci for testing ABI compatibility is failed due to this PR will indeed break ABI compatibility. However, the ABI compatibility is unimportant to device sanitizer since the user must re-build their code if they want to test their code with device sanitizer. Do you know if there is a way to disable a test under ABI compatibility testing mode?

I'm not sure @xtian-github agrees with that: #19719 (comment)

@zhaomaosu
Copy link
Contributor Author

Hi @xtian-github, could you please help review changes in 'devops/compat_ci_exclude.sycl-rel-6_3'. I disabled sanitizer tests since backward compatibility is unimportant for device sanitizer.

@zhaomaosu
Copy link
Contributor Author

Kindly ping @gmlueck, @xtian-github

Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A question: BMG is not a supported target? What is the engineering cost to enable it? Can the DG2 path be leveraged?

@cdai2
Copy link
Contributor

cdai2 commented Aug 26, 2025

LGTM.

A question: BMG is not a supported target? What is the engineering cost to enable it? Can the DG2 path be leveraged?

BMG is not a supported target. We do not validate device-side sanitizer on BMG before so we don't know the gap to support it.
We will give you feedback later.

@zhaomaosu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers, there is a pre-ci failure with hung test. And the hung issue is unrelated to this change. I add comments to issue #19786 to track this problem. Could you please help merge this PR?

@zhaomaosu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers, this PR is ready to be merged, thanks.

@steffenlarsen steffenlarsen merged commit 91a91c3 into intel:sycl Aug 27, 2025
64 of 69 checks passed
@zhaomaosu zhaomaosu deleted the san-spec-constant-devicety branch August 27, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants